[ofa-general] [PATCH] ipoib: null tx/rx_ring skb pointers on free

Ira Weiny weiny2 at llnl.gov
Thu Nov 6 09:11:13 PST 2008


On Thu, 6 Nov 2008 08:04:28 -0800
akepner at sgi.com wrote:

> On Thu, Nov 06, 2008 at 10:40:32AM +0200, Eli Cohen wrote:
> > On Wed, Nov 05, 2008 at 05:23:07PM -0800, akepner at sgi.com wrote:
> > ...
> > looking a the patch I don't understand why it should fix the problem
> > you're seeing. I suspect we may be hiding the problem.
> > 
> 
> I think that may be correct. 
> 
> For the stale skb pointers to be reused by the ipoib driver, it 
> looks like we'd need to get 'unexpected' completions. 
> 

If this is the case we could use a debug patch which Al developed here which
simply flags the skb as "invalid" but leaves the pointer.  Then we could use
that flag to determine when these "unexpected" completions are occuring.

I can get the patch from Al if you would like.

Ira




More information about the general mailing list