[ofa-general] Re: [PATCH] IPoIB: Prevent address handles leak.

Roland Dreier rdreier at cisco.com
Mon Nov 24 09:02:33 PST 2008


 > There may be some extremely slight window for leaking address handles
 > still, since the multicast list is emptied in ipoib_mcast_dev_flush() before
 > it calls ipoib_mcast_free() (which adds address handles to the dead list).
 > 
 > However, this seems to be the best compromise that I can see without
 > a lot of nasty (and possibly buggy) changes.

The impact of this bug seems very low to me, so this is 2.6.29 material
anyway.  I would really rather fix this bug for real rather than just
reducing the window and leaving the bug to cause problems in the future,
so could you try and think of a solution that doesn't leave a window at all?



More information about the general mailing list