[ofa-general] [PATCH] mlx4_ib/mthca: Fix dispatch of IB_EVENT_LID_CHANGE
Moni Shoua
monis at Voltaire.COM
Thu Nov 27 05:26:23 PST 2008
Jack Morgenstein wrote:
> On Tuesday 25 November 2008 18:06, Moni Shoua wrote:
>> @@ -263,6 +269,9 @@ int mlx4_ib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num,
>> } else
>> return IB_MAD_RESULT_SUCCESS;
>>
>> + if (!ib_query_port(ibdev, port_num, &pattr))
>> + prev_lid = pattr.lid;
>> +
>>
>
> Why do ib_query_port for each MAD that is handled? query_port involves a firmware access.
> Events are generated only for SMP SET packets.
I agreee. Thanks.
I'm also changing the action in case ib_query_port() fails.
Instead of ignoring the failure I now assume the worst (i.e: LID_CHANGE)
More information about the general
mailing list