[ofa-general] [RMDA CM IPv6 support. PATCHv4 1/6] AF_INET6 support for rdma_bind_addr

Roland Dreier rdreier at cisco.com
Sun Nov 30 13:20:37 PST 2008


    Aleksey> This is my first patch for kernel, and I thought that a
    Aleksey> smallest pieces is better, but now I'd like to say that the
    Aleksey> fat one, where all parts must to be applied together in
    Aleksey> order to work, more suitable for such change.

Yes, it's a tricky balance.  You don't want to combine multiple ideas in
one patch, because such patches are hard to review and hard to debug
later.  But splitting one ideas into multiple patches also causes
similar problems (and you have to get the pieces in the right order
too).  And of course the whole question of what constitues an "idea" is
rather subjective.  So we just do the best we can.

 - R.



More information about the general mailing list