[ofa-general] Re: [PATCH][v2.0] dat: look for dat.conf in multiple locations, including sysconfdir

Doug Ledford dledford at redhat.com
Tue Oct 14 11:31:55 PDT 2008


On Tue, 2008-10-14 at 11:09 -0700, Arlin Davis wrote:

> @@ -324,8 +343,8 @@ dat_sr_load (void)
>  cleanup:
>      dat_os_fclose(sr_file);	
>  bail:
> -    dat_os_dbg_print(DAT_OS_DBG_TYPE_ERROR, 
> -		     "ERROR: unable to parse static registry file, dat.conf\n");
> +    dat_os_dbg_print(DAT_OS_DBG_TYPE_ERROR,
> +		     "DAT Registry: dat.conf, bad filename - %s\n", sr_path);
>      return DAT_INTERNAL_ERROR;
>  
>  }

One comment...since this is where we get when we fail, and we try
multiple versions of sr_path, this error message is always going to show
just the last path we tried, and won't reflect all the paths we tried.
This might confuse people if they pass in a different location via
DAT_OVERRIDE and it isn't found, but we also try the default dat
locations and then they get this message.

-- 
Doug Ledford <dledford at redhat.com>
              GPG KeyID: CFBFF194
              http://people.redhat.com/dledford

Infiniband specific RPMs available at
              http://people.redhat.com/dledford/Infiniband

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 197 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20081014/b4b00858/attachment.sig>


More information about the general mailing list