[ofa-general] Re: [PATCH] opensm: notify master SM with trap 144 (not finished)

[Hal Rosenstock]

Sasha,

On Tue, Oct 28, 2008 at 4:27 PM, Hal Rosenstock
<hal.rosenstock at gmail.com> wrote:
> Sasha,
>
> On Sat, Oct 25, 2008 at 4:01 PM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
>>
>> When entering standby state (after discovery) notify master SM about us.
>> In case when SMA doesn't support trap sending (specifically trap 144 on
>> PortInfo:CapabilityMask change - isSM bit, example is current ConnectX
>> firmware - 2.5.0) this is only way to notify the current master SM that
>> another SM is running.
>
> So is the trap sent unconditionally (since there's no way of knowing
> whether the SMA supports this or not) ? Is the only downside the extra
> Trap/TrapRepress when the SMA does support this ?
>
> Seems to me that the right fix is to the Connect-X SMA.
>
> Also, what happens once the Connect-X SMA is fixed ? Does this code persist ?

One approach might be to conditionalize this trap when Connect-X and
ultimately on the firmware versions which don't support this. Another
would be to add an option which defaults to off and needs to be set
for Connect-X manually.

-- Hal

>
> -- Hal
>
>> See also bug#1183.
>>
>> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
>> ---
>>  opensm/opensm/osm_state_mgr.c |    2 ++
>>  1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/opensm/opensm/osm_state_mgr.c b/opensm/opensm/osm_state_mgr.c
>> index 174cee6..1576c42 100644
>> --- a/opensm/opensm/osm_state_mgr.c
>> +++ b/opensm/opensm/osm_state_mgr.c
>> @@ -1142,6 +1142,8 @@ _repeat_discovery:
>>                                         OSM_SM_SIGNAL_MASTER_OR_HIGHER_SM_DETECTED_DONE);
>>                osm_log_msg_box(sm->p_log, OSM_LOG_VERBOSE, __FUNCTION__,
>>                                "ENTERING STANDBY STATE");
>> +               /* notify master SM about us */
>> +               osm_send_trap144(sm, 0);
>>                return;
>>        }
>>
>> --
>> 1.6.0.3.517.g759a
>>
>>
>