[ofa-general] Re: [PATCH] opensm: notify master SM with trap 144 (not finished)

[Sasha Khapyorsky]

On 10:03 Wed 29 Oct     , Hal Rosenstock wrote:
> >
> > It is not unconditional. There is such code at beginning of
> > osm_send_trap144():
> >
> >        /* don't bother with sending trap when SMA supports this */
> >        if (!local &&
> >            pi->capability_mask&(IB_PORT_CAP_HAS_TRAP|IB_PORT_CAP_HAS_CAP_NTC))
> >                return 0;
> 
> Oh, I see: those bits are not on in PortInfo:CapabilityMask in the C-X SMA.
> 
> Should that just be checked against HAS_CAP_NTC as there might be
> other traps supported ?

Basically yes, HAS_CAP_NTC checking could be enough (assuming we will
not have some SMA bugs).

Sasha