[ofa-general] Re: [PATCH v3 1/2] opensm: setup routing engine when in use and delete when fail

[Eli Dorfman (Voltaire)]

Sasha Khapyorsky wrote:
> On 14:01 Sun 26 Apr     , Eli Dorfman (Voltaire) wrote:
>> No.
>> routing_engine->setup is called by osm_ucast_mgr_process()
>> and if routing algorithm fails then delete is called (and is already set).
> 
> Right. And after all on OpenSM exit destroy_routing_engines() is called
> where all routing engines (including already destroyed and yet not
> created) are destroyed using delete() method unconditionally.
> 

delete() is called conditionally from destroy_routing_engines(osm_opensm_t *osm)

	if (r->delete)
		r->delete(r->context);

Also all re(s) are cleared when created so delete is NULL if setup() was not called.

So I don't see any problem here.

Eli