[ofa-general] RE: [PATCH 4/4] ib-mgmt/ibn3 branch: libibnetdisc add windows support

[Sean Hefty]

>I would agree in general, but in this specific case it is *_osd.h -
>system dependent file which is not included directly, at least not in
>libibmad and infiniband-diags up to now (hypothetically in some
>implementations it may not exist at all).

libibmad mad.h includes mad_osd.h directly.  I added it to ibnetdisc.h, because
libibnetdisc is a new library and requires OS dependent mechanisms (i.e.
MAD_EXPORT) to export the new interfaces.  I agree in trying to keep mad_osd.h
out of the diags, but libibnetdisc is special within the diags...

I really don't have a strong preference on this, so whatever you want is fine.