[ofa-general] [PATCH 2.6.30] RDMA/cxgb3: flushed sq wr completions get inserted twice in to the cqe
Steve Wise
swise at opengridcomputing.com
Wed Apr 29 12:14:38 PDT 2009
When the sq is flushed, mark the flushed entries as not signaled so
the poll logic doesn't re-insert the cqe thinking its an out of order
completion.
The bug can cause the nfsrdma server to crash due to processing the same
completed WR twice.
Signed-off-by: Steve Wise <swise at opengridcomputing.com>
---
drivers/infiniband/hw/cxgb3/cxio_hal.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb3/cxio_hal.c b/drivers/infiniband/hw/cxgb3/cxio_hal.c
index 8d71086..62f9cf2 100644
--- a/drivers/infiniband/hw/cxgb3/cxio_hal.c
+++ b/drivers/infiniband/hw/cxgb3/cxio_hal.c
@@ -410,6 +410,7 @@ int cxio_flush_sq(struct t3_wq *wq, struct t3_cq *cq, int count)
ptr = wq->sq_rptr + count;
sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);
while (ptr != wq->sq_wptr) {
+ sqp->signaled = 0;
insert_sq_cqe(wq, cq, sqp);
ptr++;
sqp = wq->sq + Q_PTR2IDX(ptr, wq->sq_size_log2);
More information about the general
mailing list