[ofa-general] Re: [PATCH] opensm: osm_dr_path_extend can fail due to invalid hop count

[Sasha Khapyorsky]

On 11:03 Sun 02 Aug     , Hal Rosenstock wrote:
> 
> Change routine to return success/failure status rather than
> depend on debug assert
> Also, fix callers of this routine to handle this return status
> 
> Signed-off-by: Hal Rosenstock <hal.rosenstock at gmail.com>
> ---
> diff --git a/opensm/include/opensm/osm_path.h b/opensm/include/opensm/osm_path.h
> index 8d65d2c..7ef0fc5 100644
> --- a/opensm/include/opensm/osm_path.h
> +++ b/opensm/include/opensm/osm_path.h
> @@ -2,6 +2,7 @@
>   * Copyright (c) 2004-2006 Voltaire, Inc. All rights reserved.
>   * Copyright (c) 2002-2005 Mellanox Technologies LTD. All rights reserved.
>   * Copyright (c) 1996-2003 Intel Corporation. All rights reserved.
> + * Copyright (c) 2009 HNR Consulting. All rights reserved.
>   *
>   * This software is available to you under a choice of one of two
>   * licenses.  You may choose to be licensed under the terms of the GNU
> @@ -188,15 +189,18 @@ osm_dr_path_init(IN osm_dr_path_t * const p_path,
>  *
>  * SYNOPSIS
>  */
> -static inline void
> +static inline boolean_t

But why boolean? It is not logical operation, what is wrong with just int?

Sasha