[ofa-general] Re: [PATCH] opensm: fixing handling of opt.max_wire_smps

Yevgeny Kliteynik kliteyn at dev.mellanox.co.il
Wed Aug 5 04:10:42 PDT 2009


Sasha Khapyorsky wrote:
> On 13:07 Wed 05 Aug     , Yevgeny Kliteynik wrote:
>> Sasha Khapyorsky wrote:
>>> On 11:55 Wed 05 Aug     , Yevgeny Kliteynik wrote:
>>>> And since we're on this, perhaps the right thing here would
>>>> be not using OSM_DEFAULT_SMP_MAX_ON_WIRE, but the maximal
>>>> valid value (0x7FFFFFFF)?
>>> In which case? When provided max_wire_smps is 0 or invalid?
>> Both.
> 
> I think that for case of providing invalid value fallback to the default
> is better. Of course we can discuss about what the default value could
> be, but it is different story.

OK, so 0 will go to 0x7FFFFFFF, and invalid value will
fall back to default.

Patch in 3...2...1...

-- Yevgeny
 
> Sasha
> 




More information about the general mailing list