[ofa-general] Re: [PATCH] opensm/osm_ucast_file.c: Fix return status from do_ucast_file_load when file name is not provided

[Hal Rosenstock]

Hi Sasha,

On Tue, Aug 11, 2009 at 5:22 PM, Sasha Khapyorsky <sashak at voltaire.com>wrote:

> Hi Hal,
>
> On 14:19 Thu 06 Aug     , Hal Rosenstock wrote:
> > @@ -136,7 +137,7 @@ static int do_ucast_file_load(void *context)
> >               OSM_LOG(&p_osm->log, OSM_LOG_VERBOSE,
> >                       "LFTs file name is not given; "
> >                       "using default routing algorithm\n");
> > -             return 1;
> > +             return -1;
>
> This "fix" is not correct. Routing engine method returns "> 0" value
> when fallback to default is requested. In particular in case of 'file'
> engine it is legal to provide only LFTs file and not provide LID matrix
> file.


Is it supposed to use file when no files (LFT or LID matrix) are supplied ?
That's what seems to happen (with no fallback).

-- Hal


>
>
> Sasha
>  _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit
> http://openib.org/mailman/listinfo/openib-general
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20090811/b312b1fa/attachment.html>