[ofa-general] Re: [PATCH 3/5] libibnetdisc: make all fields of ibnd_fabric_t public

[Sasha Khapyorsky]

On 20:42 Thu 13 Aug     , Ira Weiny wrote:
> 
> @@ -108,8 +107,8 @@ typedef struct ibnd_port {
>  /** =========================================================================
>   * Chassis
>   */
> -typedef struct chassis {
> -	struct chassis *next;
> +typedef struct ibnd_chassis {
> +	struct ibnd_chassis *next;
>  	uint64_t chassisguid;
>  	unsigned char chassisnum;
>  
> @@ -124,11 +123,17 @@ typedef struct chassis {
>  	ibnd_node_t *linenode[LINES_MAX_NUM + 1];
>  } ibnd_chassis_t;
>  
> +/* HASH table defines */
> +#define HASHGUID(guid) ((uint32_t)(((uint32_t)(guid) * 101) ^ ((uint32_t)((guid) >> 32) * 103)))

Why should this macro be published (by moving from internal.h to
ibnetdisc.h)?

As far I can see it is only used in ibnetdisc.c, so actually we can keep
it internally and to move to this file.

Sasha