[ofa-general] [PATCH] opensm/osm_qos_policy.c: matching PR query to QoS level with pkey
Yevgeny Kliteynik
kliteyn at dev.mellanox.co.il
Wed Aug 26 01:00:53 PDT 2009
Or Gerlitz wrote:
> Yevgeny Kliteynik wrote:
>> False negatives. PR queries with PKeys (e.g. IPoIB interfaces) weren't
>> matched to their rules.
> Yevgeny,
>
> Our understanding is that the bug comes into play only for queries done
> on a partial membership pkey, do you agree?
Nope, just the other way around.
When some pkey is defined in QoS policy, it is stored
internally w/o the MSB.
When query comes with a full member pkey (such as 0xFFFF
for IPoIB), this pkey is not matched to the stored QoS
policy rule.
The fix was to treat any pkey that comes from request as
partial membership pkey. Note that this is done for the
QoS policy rules matching only. The two sides of this PR
query still have to comply to the usual IB spec pkey rules.
-- Yevgeny
> Or.
>
>
More information about the general
mailing list