[ofa-general] [PATCH] IPoIB: check multicast address format

[Jason Gunthorpe]

On Wed, Aug 26, 2009 at 12:07:51PM +0300, Or Gerlitz wrote:

> isn't Jason's approach enough for the bonding case?! I saw that your  
> patch ("bonding: clean muticast addresses when device changes type"

I think working versions of all three patches are required:
 1) Fix the bonding driver. Otherwise the right groups might not be
    joined.
 2) Check the address format, to protect against 'ip maddr add' and
    other wakkyness
 3) Fix the timeout handling, so mlid exhaustion and other SA side
    errors are handled elegantly.

All are bugs..

> and maybe also in mainline .31-rcX . However, it has the  
> down-side-effect of e.g loosing routes already set for the the bond
> while adding the underline IPoIB devices, so if Jason's patch is
> enough

Is this true? That is pretty ugly, but probably manageable..

-- 
Jason Gunthorpe <jgunthorpe at obsidianresearch.com>        (780)4406067x832
Chief Technology Officer, Obsidian Research Corp         Edmonton, Canada