[ofa-general] [PATCH] opensm/osm_ucast_mgr.c: simplify fwd tables setup flow

[Hal Rosenstock]

On 8/28/09, Sasha Khapyorsky <sashak at voltaire.com> wrote:
>
>
> Simplify (and unify) forwarding tables setup decision flow.


Seems to work for all engines but I got a failure for a test case where lash
fell back to min hop:

lash_core: ERR 4D02: Lane requirements (9) exceed available lanes (8) with
starting lane (0)
ucast_mgr_route: lash: cannot build fwd tables.
osm_ucast_mgr_process: minhop tables configured on all switches
ERR 331D: LFT of switch 0xguid is not up to date.

Prior to this change, the LFTs were pushed for this fallback case (and no
ERR 331D occured).

-- Hal

> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> ---
> opensm/opensm/osm_ucast_mgr.c |    7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/opensm/opensm/osm_ucast_mgr.c b/opensm/opensm/osm_ucast_mgr.c
> index 629f628..8ba78f8 100644
> --- a/opensm/opensm/osm_ucast_mgr.c
> +++ b/opensm/opensm/osm_ucast_mgr.c
> @@ -463,8 +463,6 @@ static void ucast_mgr_process_tbl(IN cl_map_item_t *
> p_map_item,
>                }
>        }
>
> -       set_fwd_tbl_top(p_mgr, p_sw);
> -
>        if (p_mgr->p_subn->opt.lmc)
>                free_ports_priv(p_mgr);
>
> @@ -977,8 +975,6 @@ static int ucast_mgr_build_lfts(osm_ucast_mgr_t *
> p_mgr)
>        cl_qmap_apply_func(&p_mgr->p_subn->sw_guid_tbl,
> ucast_mgr_process_tbl,
>                           p_mgr);
>
> -       ucast_mgr_pipeline_fwd_tbl(p_mgr);
> -
>        cl_qlist_remove_all(&p_mgr->port_order_list);
>
>        return 0;
> @@ -1025,8 +1021,7 @@ static int ucast_mgr_route(struct osm_routing_engine
> *r, osm_opensm_t * osm)
>
>        osm->routing_engine_used = osm_routing_engine_type(r->name);
>
> -       if (r->ucast_build_fwd_tables)
> -               osm_ucast_mgr_set_fwd_table(&osm->sm.ucast_mgr);
> +       osm_ucast_mgr_set_fwd_table(&osm->sm.ucast_mgr);
>
>        return 0;
> }
> --
> 1.6.4
>
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
>
> To unsubscribe, please visit
> http://openib.org/mailman/listinfo/openib-general
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openfabrics.org/pipermail/general/attachments/20090828/da48cd5a/attachment.html>