[ofa-general] Re: [PATCH 4/5] infiniband-diags/libibnetdisc: Introduce a context object.

[Ira Weiny]

Hey Sasha,

On Sun, 23 Aug 2009 15:06:09 +0300
Sasha Khapyorsky <sashak at voltaire.com> wrote:

> Hi Ira,
> 
> On 08:30 Mon 17 Aug     , Ira Weiny wrote:
> > 
> > The immediate benefit is coming with the multi-threaded implementation where
> > I plan on adding the following function.[*]

The discussion on the list has digressed from this patch.  I still think this
patch is valid and adds a level of flexibility which is needed regardless of
what is decided about libibmad.  Do you agree?

Also, the last patch in the series ([PATCH 5/5] infiniband-diags/libibnetdisc:
remove members of the fabric struct which are used in the scan only) cleans up
some stuff from the external interface.  If you really don't want to introduce
a context object, then I can regenerate that final patch without the context.

Ira

> 
> Ok, but could we discuss first how will multithreading architecture be
> implemented with libibnetdisc: goals (in particular is it support for
> multithreaded apps or just multithreaded discovery function), interaction
> with caller application, etc.?
> 
> One of the desired feature of this I could think would be to keep API
> simple for single threaded stuff.
> 
> Sasha


-- 
Ira Weiny
Math Programmer/Computer Scientist
Lawrence Livermore National Lab
925-423-8008
weiny2 at llnl.gov