***SPAM*** Re: [ofa-general] Re: [PATCH][TRIVIAL] opensm/osm_node.h: osm_node_get_num_physp description fix

[Hal Rosenstock]

On Wed, Feb 4, 2009 at 2:02 PM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> On 13:41 Wed 04 Feb     , Hal Rosenstock wrote:
>> Sasha,
>>
>> On Wed, Feb 4, 2009 at 1:25 PM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
>> > Hi Hal,
>> >
>> > On 07:57 Tue 03 Feb     , Hal Rosenstock wrote:
>> >>
>> >> Trivial description change to osm_node_get_num_physp.
>> >
>> > It makes some troubles for me to comment over attachments... :(
>> >
>> > In this comment line:
>> >
>> > +*      Returns the number of physical ports (+1) for this node.
>> >
>> > "(+1)" will not be true for switch nodes.
>>
>> Are you sure about that ? It's not what I see regardless of whether
>> base or enhanced SP0.
>
> For switch it will be an actual number of allocated physical ports
> (struct osm_physp) - port 0 olus number of external ports. For non
> switch nodes entry '0' is not used.

Right. In my terms, physical is another name for an external port and
port 0 is not a physical (external) port so I think we're quibbling
about words. What do you think it should say ?

-- Hal

> Sasha
>