[ofa-general] Re: [PATCH] opensm/osm_perfmgr_db.c: In bad_node_port, allow queries on enhanced SP0

Sasha Khapyorsky sashak at voltaire.com
Wed Feb 4 12:55:20 PST 2009


On 14:54 Wed 04 Feb     , Hal Rosenstock wrote:
> >
> > (osm_get_node_by_guid()) is expensive operation. If you only need to
> > determine port 0 type - store it as part of struct monitored_node
> > structure. Another (even more universal) approach would be to keep there
> > a reference to related osm_node object.
> 
> This was done later in the patch series.

Good, but why do we need this intermediate version then? It would be
better to do right things from beginning I think (and also this patch
depends on previous one where redirection table size was changed so I
cannot apply it anyway until things will be clarified or fixed there).

Sasha



More information about the general mailing list