[ofa-general] Re: [PATCH 2.6.30 2/2] RDMA/cxgb3: Connection termination fixes.

Steve Wise swise at opengridcomputing.com
Fri Feb 6 13:32:54 PST 2009


Roland Dreier wrote:
>  > +		BUG_ON((*cqe_flushed == 0) && !SW_CQE(*hw_cqe));
>
> BUG_ON()s are kind of nasty -- possibly killing the whole box because of
> a driver issue or an unanticipated HW quirk -- is there any way to
> report this problem and try to limp on?
>   

I'm not sure I agree with trying to limp on. This BUG_ON() doesn't 
indicate a HW quirk. It indicates the driver logic is busted. Isn't that 
what BUG_ON() should be used for?

Steve.




More information about the general mailing list