[ofa-general] Re: [PATCH 2.6.30 2/2] RDMA/cxgb3: Connection termination fixes.

[Steve Wise]

Roland Dreier wrote:
>  > I'm not sure I agree with trying to limp on. This BUG_ON() doesn't
>  > indicate a HW quirk. It indicates the driver logic is busted. Isn't
>  > that what BUG_ON() should be used for?
>
> Yeah, I guess so -- the only issue is that it's very annoying for some
> buggy driver to kill the whole system when only some non-critical piece
> is busted.  
>   
I agree with you there.  But I think trying to gracefully bail on on 
these conditions is painful and complicated and prone to resulting in a 
BUG_ON() somewhere else. :)