[ofa-general] [PATCH 2/4 v2] opensm/osm_state_mgr.c rescan subnet configuration after SIGHUP

[Sasha Khapyorsky]

On 15:47 Mon 09 Feb     , Eli Dorfman (Voltaire) wrote:
> Sasha Khapyorsky wrote:
> > Hi Eli,
> > 
> > On 21:23 Sun 08 Feb     , Eli Dorfman wrote:
> >> yes, but wouldn't it be better to separate between heavy sweep and
> >> config rescan (due to SIGHUP).
> > 
> > SIGHUP main purpose always was to trigger heavy sweep.
> > 
> >> I think that user should know when configuration is updated and not
> >> wait for heavy sweep.
> > 
> > I'm not following - SIGHUP will cause heavy sweep and config update,
> > where is a waiting?
> > 
> 
> i meant that if the user is changing config file and there is a heavy sweep then
> config may be updated,

Are you about race between file reading (by OpenSM) and writing (by
user)? Using write lock on reading would solve an issue.

> while using specific flag for config rescan will avoid this case.

What do you mean by "specific flag"? Using separate signal? Assuming so,
this will not prevent read/write race.

Sasha