[ofa-general] [PATCH 2.6.30] RDMA/cxgb3: Remove modulo math.
Roland Dreier
rdreier at cisco.com
Tue Feb 10 16:38:03 PST 2009
I'll roll this into the offending patch (that is in -next).
But:
> - wqe->recv.sgl[i].to = cpu_to_be64(((u32) wr->sg_list[i].addr) %
> - (1UL << (12 + page_size[i])));
> + wqe->recv.sgl[i].to = cpu_to_be64(((u64) wr->sg_list[i].addr) &
> + ((1UL << (12 + page_size[i]))-1));
Is this required? Strength reduction optimization should do this
automatically (and the code has been there for quite a while, so
obviously it isn't causing problems)
- R.
More information about the general
mailing list