[ofa-general] [PATCH 2.6.30] RDMA/cxgb3: Remove modulo math.
Steve Wise
swise at opengridcomputing.com
Wed Feb 11 07:44:42 PST 2009
Roland Dreier wrote:
> I'll roll this into the offending patch (that is in -next).
>
> But:
>
> > - wqe->recv.sgl[i].to = cpu_to_be64(((u32) wr->sg_list[i].addr) %
> > - (1UL << (12 + page_size[i])));
> > + wqe->recv.sgl[i].to = cpu_to_be64(((u64) wr->sg_list[i].addr) &
> > + ((1UL << (12 + page_size[i]))-1));
>
> Is this required? Strength reduction optimization should do this
> automatically (and the code has been there for quite a while, so
> obviously it isn't causing problems)
>
> - R.
>
Note that wr->sg_list[i].addr was being cast to a u32. That was wrong.
More information about the general
mailing list