[ofa-general] Re: [PATCH] opensm/osm_ucast_mgr.c: Add error numbers for some OSM_LOG prin

[Sasha Khapyorsky]

On 12:03 Sat 14 Feb     , Hal Rosenstock wrote:
> >
> > Please don't put this line ("From ...") in patch message body - it marks
> > start of message in mbox file format and breaks things like 'git rebase'
> > and similar. (At least mask this line with '> ' character).
> 
> Looks to me like it was >From but I'll try to remember to strip this.

I added '>' to 'From ...' by hand during commit using 'git commit --amend'
(for each patch).

> 
> >> From: Hal Rosenstock <hal.rosenstock at gmail.com>
> >> Date: Tue, 10 Feb 2009 07:14:32 -0500
> >> Subject: [PATCH] opensm/osm_ucast_mgr.c: Add error numbers for some OSM_LOG prints
> >
> > Actually there is no reason to repeat email header in a commit message.
> 
> So you just want the email subject and that stripped from the commit log ?

Normally email subject is used as patch description and email up to '---'
line as commit message. You can put any text which is not part of
commit message under '---' and before diffstat lines.

You may want to look at

http://git.kernel.org/?p=git/git.git;a=blob_plain;f=Documentation/SubmittingPatches;hb=HEAD

(or similar paper in kernel source tree) for more detailed explanations.

Sasha