[ofa-general] ***SPAM*** opensm/osm_inform.c:__match_inf_rec question

[Sasha Khapyorsky]

On 17:56 Tue 17 Feb     , Hal Rosenstock wrote:
> In opensm/osm_inform.c:__match_inf_rec, around line 123, there is:
> 
>         /* if inform_info.gid is not zero, ignore lid range */
>         if (!memcmp(&p_infr_rec->inform_record.inform_info.gid, &all_zero_gid,
>                     sizeof(p_infr_rec->inform_record.inform_info.gid))) {
> 
> Shouldn't this be if (memcmp) rather than if (!memcmp) ?

Yes, seems it should be without '!'. I can track it up to:

commit ce7f839355b9674c8d806747169d404066194235
Author: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>
Date:   Mon Nov 27 16:08:42 2006 +0000

    r10169: OpenSM: Comparing InformInfo records

, where this code was introduced.

Yevgeny! Do you remember was it just a typo?

Sasha