***SPAM*** Re: ***SPAM*** Re: [ofa-general] [PATCH 1/10] libibmad: Clean up "new" interface

[Hal Rosenstock]

On Fri, Feb 20, 2009 at 8:41 AM, Hal Rosenstock
<hal.rosenstock at gmail.com> wrote:
> On Thu, Feb 19, 2009 at 10:05 PM, Ira Weiny <weiny2 at llnl.gov> wrote:
>> >From 2774b4ab4608e25bdc365bca3a94c7d51ee19372 Mon Sep 17 00:00:00 2001
>> From: Ira Weiny <weiny2 at llnl.gov>
>> Date: Wed, 18 Feb 2009 16:37:36 -0800
>> Subject: [PATCH] libibmad: Clean up "new" interface
>>
>>   type all "void *ibmad_port" and "void *srcport" with struct ibmad_port *
>>   Create new mad_rpc_portid(struct ibmad_port *srcport) function
>>      which mirrors madrpc_portid(void)
>>   Mark all "old" functions with __attribute__ ((deprecated))
>>
>> Signed-off-by: Ira Weiny <weiny2 at llnl.gov>
>> ---
>>  libibmad/include/infiniband/mad.h |  139 ++++++++++++++++++++++---------------
>>  libibmad/src/gs.c                 |   19 +++---
>>  libibmad/src/libibmad.map         |    1 +
>>  libibmad/src/resolve.c            |   10 ++-
>>  libibmad/src/rpc.c                |   29 ++++----
>>  libibmad/src/sa.c                 |    4 +-
>>  libibmad/src/smp.c                |    4 +-
>>  7 files changed, 118 insertions(+), 88 deletions(-)
>>
>> diff --git a/libibmad/include/infiniband/mad.h b/libibmad/include/infiniband/mad.h
>> index 1aaaa1b..80e38be 100644
>> --- a/libibmad/include/infiniband/mad.h
>> +++ b/libibmad/include/infiniband/mad.h
>> @@ -724,100 +724,125 @@ static inline int mad_is_vendor_range2(int mgmt)
>>  }
>>
>>  /* rpc.c */
>> -MAD_EXPORT int madrpc_portid(void);
>> -MAD_EXPORT int madrpc_set_retries(int retries);
>> -MAD_EXPORT int madrpc_set_timeout(int timeout);

retries and timeouts could also be made per ibmad_port struct basis
rather than one for all clients. Those two APIs would be deprecated in
favor of new ones (mad_rpc_set_retries/timeout).

-- Hal

<snip...>