[ofa-general] Re: [PATCH v2] opensm/osm_node_info_rcv.c: create physp for the newly discovered port of the known node

[Sasha Khapyorsky]

On 14:22 Thu 26 Feb     , Yevgeny Kliteynik wrote:
> Hi Sasha,
> 
> [v2: adding CL_ASSERT() and changing comments]
> 
> This patch fixes bugzilla issue #1515.
> 
> The bug was discovered and analyzed by Line Holen.
> 
> Topology:
>                  |---------------|
>                  |      SW2      |
>                  |---------------|
>                    |x |y    |z |v
>               |----|  |     |  |----|
>               |       |     |       |
>               |  |----|     |----|  |
>               |  |               |  |
>              a| b|              c| d|
>       |---------------|     |---------------|
>       |       SW1     |     |     SW3       |
>       |---------------|     |---------------|
>           |                             |
>           |                             |
>        HCA with SM                      HCA
> 
> During the discovery:
> 
> SM sends NodeInfo request to SW1
> SM sends NodeInfo request to SW2 through link a->x
> SM discovers new node SW2:
>   - updates DR to SW2 to go through link a->x
>   - creates physp x
> SM sends NodeInfo request to SW2 through link b->y
> SM discovers a known node SW2
>   - DOES NOT create physp y
>   - updates DR to SW2 to go through link b->y
> 
> From now on, the DR to SW2 is going through port y, so OpenSM won't deal with
> port y any more, leaving it uninitialized (no physp object for this port).
> 
> The fix is to create physp for the newly discovered port of the known
> switch node, same way as it is done for HCAs.
> I also added one log message for the case that showed the problem - when
> one of the link sides is uninitialized (no valid ports check). Perhaps
> this log message should be an error message instead?
> 
> Debugged-by: Line Holen <Line.Holen at Sun.COM>
> Signed-off-by: Yevgeny Kliteynik <kliteyn at dev.mellanox.co.il>

Applied. Thanksa.

Sasha