***SPAM*** Re: [ofa-general] Re: [PATCH] opensm/console: Enhance perfmgr print_counters for better nodenames
Jason Gunthorpe
jgunthorpe at obsidianresearch.com
Fri Feb 27 13:10:33 PST 2009
On Fri, Feb 27, 2009 at 01:53:19PM -0500, Hal Rosenstock wrote:
> On Fri, Feb 27, 2009 at 4:24 AM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> > On 07:03 Thu 26 Feb ?? ?? , Hal Rosenstock wrote:
> >> On Thu, Feb 26, 2009 at 1:15 AM, Sasha Khapyorsky <sashak at voltaire.com> wrote:
> >>
> >> [snip...]
> >>
> >> > And in general I think it is better to use C-style comments - /* ... */,
> >> > in C code and not C++-style // ... .
> >>
> >> Is this going to be enforced uniformly across OpenSM ?
> >
> > I didn't think about it (there are no many '//' comments), but I try to
> > not introduce a new ones.
>
> Sent some patches relative to this. I'm not willing to take on
> ib_types.h right now. Maybe someone else will.
Is this really worth doing? // is included in C99 and many other
C99isms are already used in the source (well, until Sean removes
them.. :)
Jason
More information about the general
mailing list