[ofa-general] [PATCH] ipoib: failure during startup wiith non-default pkey set.

[Roland Dreier]

a) checkpatch.pl says:

ERROR: trailing whitespace
#11: FILE: drivers/infiniband/ulp/ipoib/ipoib_ib.c:724:
+^I$

ERROR: trailing whitespace
#13: FILE: drivers/infiniband/ulp/ipoib/ipoib_ib.c:726:
+^I^I$

WARNING: braces {} are not necessary for single statement blocks
#19: FILE: drivers/infiniband/ulp/ipoib/ipoib_ib.c:732:
+		if (port_attr.state != IB_PORT_ACTIVE) {
+			return;
+		} 

ERROR: trailing whitespace
#21: FILE: drivers/infiniband/ulp/ipoib/ipoib_ib.c:734:
+^I^I} $

total: 3 errors, 1 warnings, 38 lines checked

and as far as I can see, all of the errors and warnings are valid.  I'm
tired of fixing this type of crap up by hand, so until you send me a
clean patch, I'm not going to apply this.

b) I understand the issue you're trying to fix, but thinking about this,
it seems that rather than picking the first entry in the p_key table
happens to be for the main IPoIB interface, it would be simpler to
understand if we just always used P_Key 0xffff for the main interface
and let the user create whatever other interfaces desired for other
P_Keys.  Then there wouldn't be any race, and the situation would be
easy to understand and manage.

 - R.