[ofa-general] Re: [PATCH] libibumad: Add sysfs_*() functions to libibumad.map

[Sasha Khapyorsky]

Hi Vladimir,

On 13:38 Mon 29 Dec     , Vladimir Sokolovsky wrote:
> Signed-off-by: Vladimir Sokolovsky <vlad at mellanox.co.il>
> ---
>  libibumad/src/libibumad.map |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)
> 
> diff --git a/libibumad/src/libibumad.map b/libibumad/src/libibumad.map
> index 0154b7f..ea8999e 100644
> --- a/libibumad/src/libibumad.map
> +++ b/libibumad/src/libibumad.map
> @@ -30,5 +30,10 @@ IBUMAD_1.0 {
>  		umad_debug;
>  		umad_addr_dump;
>  		umad_dump;
> +		sys_read_gid;
> +		sys_read_guid;
> +		sys_read_string;
> +		sys_read_uint;
> +		sys_read_uint64;
>  	local: *;
>  };

I don't think we should expose those functions in libibumad (btw there
are no those prototypes in umad.h).

It would be better to reimplement related stuff in srptools - simplest
workaround could be just copying needed sys_*() functions, but better is
to use libibvers calls (as Sean suggested) and to drop libibcommon
dependency (note that I'm planning to remove this library completely
soon, the patch was on the list already).

Sasha