[ofa-general] Re: [PATCH] opensm: update LFTs when entering master state

[Yevgeny Kliteynik]

Hi Sasha,

Sasha Khapyorsky wrote:
> When we are going to setup LFTs we need to ignore its previous images if
> OpenSM enters master after standby, so need to check for subnet
> need_update flag too.

Nice catch. I think there will be a similar problem with
cached routing too - need to invalidate the cache when SM
enters master state.

-- Yevgeny

> Actually this should fix bug#1469.
> 
> Signed-off-by: Sasha Khapyorsky <sashak at voltaire.com>
> ---
>  opensm/opensm/osm_ucast_mgr.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/opensm/opensm/osm_ucast_mgr.c b/opensm/opensm/osm_ucast_mgr.c
> index d332b36..96921a0 100644
> --- a/opensm/opensm/osm_ucast_mgr.c
> +++ b/opensm/opensm/osm_ucast_mgr.c
> @@ -400,7 +400,7 @@ int osm_ucast_mgr_set_fwd_table(IN osm_ucast_mgr_t * const p_mgr,
>  	for (block_id_ho = 0;
>  	     osm_switch_get_lft_block(p_sw, block_id_ho, block);
>  	     block_id_ho++) {
> -		if (!p_sw->need_update &&
> +		if (!p_sw->need_update && !p_mgr->p_subn->need_update &&
>  		    !memcmp(block,
>  			    p_sw->new_lft + block_id_ho * IB_SMP_DATA_SIZE,
>  			    IB_SMP_DATA_SIZE))