[ofa-general] [PATCH 1/3 v2] libibmad. 2nd revision for WinOF portablity.

Sean Hefty sean.hefty at intel.com
Wed Jan 21 07:51:29 PST 2009


>> >What about to use c99_to_whatever preprocessor
>> >(sed -e 's/\[.*\] *= *//')?
>>
>> I don't think this helps.  Unless the definitions are in the correct
>location,
>
>Sure. And obviously I was about more sofisticated preprocessor ([]
>constans should be evaluated and an array sorted properly, etc).

I think all of this is overkill.  Is it really that difficult to ensure that new
fields are placed into the array correctly, especially compared to the cost,
say, of ensuring that the field offsets are correct or maintaining an additional
pre-processing script?  We're reducing the broader maintenance costs overall by
having a single code base.

Is this is only open issue integrating the ib-mgmt WinOF support changes?

- Sean




More information about the general mailing list