[ofa-general] [PATCH 1/3 v2] libibmad. 2nd revision for WinOF portablity.
Sasha Khapyorsky
sashak at voltaire.com
Wed Jan 21 16:54:16 PST 2009
On 11:02 Tue 20 Jan , Davis, Arlin R wrote:
>
> Like Sean said, until WinOF changes the build enviroment we have
> no choice. The majority of the changes went into field.c and given
> the structure includes a character field with the mad field name
> I would think maintainability is preserved. I added your recent
> PortXmitWait and CounterSelect2 changes with no problem.
Ok. This is really minor in this specific case (once ib_mad_f array is
properly ordered). I'm going to apply three patches.
But for future (bigger components - infiniband-diags, OpenSM, etc.),
please, please, please, evaluate in WinOF possibility to use portable
tools - IMO it should be a reasonable price for portability (needless
to say that it save a lot of time and work from WinOF guys at first
place).
Sasha
More information about the general
mailing list