[ofa-general] Re: [PATCH 02/21] RDS: Main header file

[Rémi Denis-Courmont]

On Tuesday 27 January 2009 04:17:39 ext Andy Grover, you wrote:
> +/*
> + * XXX randomly chosen, but at least seems to be unused:
> + * #               18464-18768 Unassigned
> + * We should do better.  We want a reserved port to discourage unpriv'ed
> + * userspace from listening.
> + */
> +#define RDS_PORT	18634

Internet transport protocol port number? IANA has a process for assigning port 
numbers to proprietary protocols.

Not that I'd blame you, as I inherited VLC media player's wide abuse of port 
1234 as its current network core maintainer :(

> +#ifndef AF_RDS
> +#define AF_RDS          28      /* Reliable Datagram Socket     */
> +#endif
> +
> +#ifndef PF_RDS
> +#define PF_RDS          AF_RDS
> +#endif

You should probably remove that and put the last patch of your series ahead of 
this one.

> +#ifndef SOL_RDS
> +#define SOL_RDS         272
> +#endif

This is used by RXRPC nowadays, although I myself don't really understand why 
socket option levels need to be unique across all families.

-- 
Rémi Denis-Courmont
Maemo Software, Nokia Devices R&D