[ofa-general] Re: [ewg] [PATCH] ib_core: save process's virtual address in struct ib_umem

[Eli Cohen]

On Mon, Jan 26, 2009 at 10:26:25AM -0800, Roland Dreier wrote:
>  > It is has to be saved either at the low level driver's mr object,
>  > e.g. struct mlx4_ib_mr, or at a common place like struct ib_umem. Do
>  > you prefer that it will be saved in struct mlx4_ib_mr?
> 
> I don't see why it has to be saved anywhere?  The only place you use
> umem->address is in handle_hugetlb_usermr(), and you could just as
> easily pass in start directly as a parameter (since
> mlx4_ib_reg_user_mr() has that value in a parameter anyway).
> 

Sorry for the delayed response.
I see... you're right - no need to stick the address into struct
ib_umem. Following this email is a new patch for mlx4_ib only. I
excluded support for both powerpc and ia64 since I could not find a
way to get HPAGE_SIZE (or HPAGE_SHIFT) for them.