[ofa-general] Re: A question about tx lock in ipoib_flush_paths

Roland Dreier rdreier at cisco.com
Wed Jul 8 15:31:32 PDT 2009


 > Couldn't ipoib_start_xmit() grab ipoib_neigh, and cause the same thing the
 > commit above was intended to fix?

I don't see how -- either ipoib_start_xmit runs before the flush task
grabs the tx lock, in which case it uses the path and exits before the
flush task runs, or ipoib_start_xmit runs after the flush task releases
the lock, in which case the path is already removed from the path rbtree
and hence won't be found by ipoib_start_xmit.  Of course I could easily
be missing something.



More information about the general mailing list