[ofa-general] Re: [PATCH V2] mlx4: check for FW version which properly supports resize_cq

[Jack Morgenstein]

On Thursday 09 July 2009 18:10, Roland Dreier wrote:
> Or maybe it's cleaner to add a stub resize_cq method that just returns
> ENOSYS that drivers can set when they don't actually implement it...
> 
Basically, that is what the patch I submitted to you does.
Its just that instead of having a different call which returns -ENOSYS
and doing the test in the mlx4_ib_add function, I do it in the resize_cq
function.

If you prefer (i.e., if you think it is cleaner), I can do what you suggest
above (and submit a new patch) -- do the version test when populating the
virtual function table), and simply link resize_cq to a stub function which
returns -ENOSYS if the installed fw version does not support resize_cq.

-Jack