[ofa-general] [PATCH v2] mthca: Distinguish multiple IB cards in /proc/interrupts

Roland Dreier rdreier at cisco.com
Fri Jul 10 15:15:08 PDT 2009


 > @@ -356,6 +356,7 @@ struct mthca_dev {
 >         struct ib_ah         *sm_ah[MTHCA_MAX_PORTS];
 >         spinlock_t            sm_lock;
 >         u8                    rate[MTHCA_MAX_PORTS];
 > +       char                  irq_name[MTHCA_NUM_EQ][IB_DEVICE_NAME_MAX];

This patch is whitespace-mangled (tabs are gone).  So it can't be
applied.  Please fix your MTA and resend so it will apply.

 > +                       snprintf(&dev->irq_name[i][0], IB_DEVICE_NAME_MAX,

I would probably write

 &dev->irq_name[i][0]

as just

 dev->irq_name[i]

 > +               snprintf(&dev->irq_name, IB_DEVICE_NAME_MAX,

The first parameter of snprintf is a char *.  Doesn't "&dev->irq_name"
have type char ***?

 - R.



More information about the general mailing list