[ofa-general] Re: [ewg] [PATCH 1/8 v3] ib_core: Add API to support RDMAoE

[Eli Cohen]

On Mon, Jul 13, 2009 at 03:26:06PM -0400, Hal Rosenstock wrote:
> >
> > +enum ib_port_link_type ib_get_port_link_type(struct ib_device *device, u8 port_num)
> > +{
> > +       return device->get_port_link_type ?
> > +               device->get_port_link_type(device, port_num) : PORT_LINK_IB;
> 
> So do iWARP devices return PORT_LINK_IB ? If so, that seems a little
> weird to me.
> 
> -- Hal
> 

Maybe it's more appropriate to make this function mandatory and
require all drivers to report the correct port type. What do you
think?