[ofa-general] Re: [ewg] [PATCH 2/8 v3] ib_core: RDMAoE support only QP1

[Hal Rosenstock]

On Mon, Jul 13, 2009 at 4:58 PM, Woodruff, Robert
J<robert.j.woodruff at intel.com> wrote:
> Eli Cohen wrote,
>
>>Since RDMAoE is using Ethernet as its link layer, there is no need for QP0. QP1
>>is still needed since it handles communications between CM agents. This patch
>>will create only QP1 for RDMAoE ports.
>
>
> Trying to emulate IB for mad services is a total hack and not how this
> new transport should be added into the core. It should be it's own transport type,
> just like iWarp was added.
> You should start with adding a new transport type to ib_verbs.h,
> e.g.,
>
>
> --- ib_verbs.h  2009-07-13 09:06:10.000000000 -0400
> +++ ib_verbs_new.h      2009-07-14 03:00:23.000000000 -0400
> @@ -64,12 +64,14 @@ enum rdma_node_type {
>        RDMA_NODE_IB_CA         = 1,
>        RDMA_NODE_IB_SWITCH,
>        RDMA_NODE_IB_ROUTER,
> -       RDMA_NODE_RNIC
> +       RDMA_NODE_RNIC,
> +       RDMA_NODE_IBXOE
>  };
>
>  enum rdma_transport_type {
>        RDMA_TRANSPORT_IB,
> -       RDMA_TRANSPORT_IWARP
> +       RDMA_TRANSPORT_IWARP,
> +       RDMA_TRANSPORT_IBXOE
>  };
>
>  enum rdma_transport_type

Unfortunately I don't think it's this simple although I wish it were.
IBXOE is on a per port rather than a per node basis which is a
different model than we've used for IB or iWARP.

-- Hal