[ofa-general] Re: [PATCH V2] mlx4: check for FW version which properly supports resize_cq

[Jack Morgenstein]

On Wednesday 15 July 2009 01:33, Roland Dreier wrote:
> It occurs to me that one change that makes sense and would help make
> this fix cleaner is the following -- since after all if a command # is
> out of range, that's really a different error than if a low-level driver
> just doesn't implement a certain method.
> 
This is exactly the patch I posted on Dec 2, 2008:
   http://lists.openfabrics.org/pipermail/general/2008-December/055734.html

However, see my comments accompanying the patch.  This is a global change for
all verbs -- and I'm not sure that it won't break some current applications.

MPI is OK with this change, however (in fact, MPI needs this change -- see the next
post in the openfabrics list thread above).

I suggest that you post to ewg, indicating the change (-ENOSYS for unimplemented
commands instead of -EINVAL) and see if anyone responds.  If it is OK, then you should
just do it.

-Jack