[ofa-general] Re: [PATCH] opensm/osm_perfmgr.c: In perfmgr_send_pc_mad, only set CounterSelect when Set method is used

Hal Rosenstock hal.rosenstock at gmail.com
Mon Jul 20 10:20:44 PDT 2009


On Mon, Jul 20, 2009 at 12:29 PM, Sasha Khapyorsky<sashak at voltaire.com> wrote:
> On 10:20 Mon 20 Jul     , Hal Rosenstock wrote:
>> >
>> > Then what was wrong with an initialization on a Get?
>>
>> Your words not mine :-) I didn't say anything was wrong. Both are
>> right but why initialize something that doesn't need it.
>
> In order to save not actually "if ()" statement.

Right; it's the tradeoff of the if v. the additional initialization(s).

>> Also, this is
>> future looking as I expect more of such shortly so at what point is it
>> worth it ?
>
> What do you mean?

I expect more initializations like this shortly based on the patches
currently being discussed on the list.

-- Hal

> Sasha
>



More information about the general mailing list