[ofa-general] Re: [PATCH ibverbs] Make the gid argument to ibv_attach_mcast and ibv_detach_mcast const

[Roland Dreier]

 > Seems to me that you are creating cross-library
 > dependencies (at least with regard to compiler warnings) -- the user will now be
 > required to change the device libraries if libibverbs is upgraded.  Also, if the
 > device libraries get changed, but libibverbs stays the same, I think you will also
 > get warnings if anyone tries to compile user-level apps.

This doesn't seem right to me.  The change to use ibv_cmd_xxx in driver
libraries should not generate warnings with either old or new
libibverbs, since the prototypes match in all versions of libibverbs.
And in any case device libraries should have no effect on user-level
apps at all.

Then the change to the user-level verbs to add const should also not add
any more warnings -- since passing non-const into a const parameter is
fine; the issue is the other way around, which is what Jason's change fixes.