[ofa-general] [PATCH ibverbs] Do not use enum object types for bitfields
Roland Dreier
rdreier at cisco.com
Thu Jul 23 14:09:11 PDT 2009
Thanks... I guess we can take a stab at doing this and see if anyone
breaks because of it.
I do notice that this patch doesn't update the man pages and therefore
leaves them out of sync with the actual code. And that makes me notice
that by going from "enum ibv_foo foo" to "int foo" we lose the nice
self-documenting property of the API that it tells you what set of flags
are supposed to be used there. I guess we should make sure that at
least all the interfaces in verbs.h used by applications (as opposed to
driver stuff in driver.h) document what enum contains the flags that go
into each parameter.
- R.
More information about the general
mailing list