[ofa-general] [PATCH] IB/IPoIB: Don't let a bad muticast address in the join list stop subsequent joins

[Moni Shoua]

Roland,
With Jason's example of corrupting mcast list of IPoIB from userspace, what do you think about the necessity of the patch?

Moni Shoua wrote:
>>> Is there any way userspace can inject a bogus multicast address?
>> Can you do it with netlink?
>>
>> ip maddr add address ... dev ib0  
>>
>> Jason
> 
> Thanks Jason. This is an example that shows it can be done from userspace.
> Roland, I think that the output below answers your question.
> 
> 
> Before ip maddr show
> -------------------------------
> linux:/etc/sysconfig/network # ip m s dev ib0
> 9:      ib0
>         link  00:ff:ff:ff:ff:12:60:1b:ff:ff:00:00:00:00:00:01:00:00:00:00
>         link  00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:00:00:00:00
>         link  00:ff:ff:ff:ff:12:60:1b:ff:ff:00:00:00:00:00:00:00:00:00:00
>         inet  224.0.0.1
>         inet6 ff02::1:ff96:ca05
>         inet6 ff02::1
> 
> linux:/etc/sysconfig/network # ip maddr add 33:33:00:00:00:01 dev ib0
> linux:/etc/sysconfig/network # ip m s dev ib0
> 
> Before ip maddr show
> -------------------------------
> 9:      ib0
>         link  33:33:00:00:00:01:00:00:00:00:00:00:00:00:00:00:00:00:00:00 static
>         link  00:ff:ff:ff:ff:12:60:1b:ff:ff:00:00:00:00:00:01:00:00:00:00
>         link  00:ff:ff:ff:ff:12:40:1b:ff:ff:00:00:00:00:00:00:00:00:00:00
>         link  00:ff:ff:ff:ff:12:60:1b:ff:ff:00:00:00:00:00:00:00:00:00:00
>         inet  224.0.0.1
>         inet6 ff02::1:ff96:ca05
>         inet6 ff02::1
> 
>>From dmesg (22 means EINVAL)
> -------------------------------
> ib0: multicast join failed for 0001:0000:0000:0000:0000:0000:0000:0000, status -22
> ib0: multicast join failed for 0001:0000:0000:0000:0000:0000:0000:0000, status -22
> ib0: multicast join failed for 0001:0000:0000:0000:0000:0000:0000:0000, status -22
> ib0: multicast join failed for 0001:0000:0000:0000:0000:0000:0000:0000, status -22
> ib0: multicast join failed for 0001:0000:0000:0000:0000:0000:0000:0000, status -22
> ib0: multicast join failed for 0001:0000:0000:0000:0000:0000:0000:0000, status -22
> ib0: multicast join failed for 0001:0000:0000:0000:0000:0000:0000:0000, status -22
> ib0: multicast join failed for 0001:0000:0000:0000:0000:0000:0000:0000, status -22
> _______________________________________________
> general mailing list
> general at lists.openfabrics.org
> http://lists.openfabrics.org/cgi-bin/mailman/listinfo/general
> 
> To unsubscribe, please visit http://openib.org/mailman/listinfo/openib-general
>