[ofa-general] Re: [PATCHv2] opensm/osm_ucast_lash.c: Handle malloc failures better

Sasha Khapyorsky sashak at voltaire.com
Fri Jul 31 10:01:12 PDT 2009


On 13:54 Thu 30 Jul     , Hal Rosenstock wrote:
> @@ -800,7 +806,11 @@ static int lash_core(lash_t * p_lash)
>  	for (i = 0; i < num_switches; i++) {
>  
>  		shortest_path(p_lash, i);
> -		generate_routing_func_for_mst(p_lash, i, &dests);
> +		if (generate_routing_func_for_mst(p_lash, i, &dests)) {
> +			OSM_LOG(p_log, OSM_LOG_ERROR,
> +				"generate_routing_func_for_mst failed\n");
> +			goto Exit;

In this case lash_core() will return value of 'status' variable which is
zero and indicates a success. No?

Sasha

> +		}
>  
>  		idest = dests;
>  		while (idest != NULL) {
> 



More information about the general mailing list