[ofa-general] ibdiagnet: invalid bareword "pkey_entry"

[akepner at sgi.com]

(Yevgeny, looks like you're maintaining ibutils. Please let me 
know if it's otherwise.)

We're getting this:

# ibdiagnet
.....
-I---------------------------------------------------
-I- Fabric Partitions Report (see ibdiagnet.pkey for a full hosts list)
-I---------------------------------------------------
invalid bareword "pkey_entry"
in expression "-pkey_entry & 0x7fff";
should be "$pkey_entry" or "{pkey_entry}" or "pkey_entry(...)" or ...
# 


when running ibdiagnet. 

Any idea why we're seeing this now, when we haven't before?

The following fixes it, but maybe there's a better way (it's 
the first line of tcl I've ever written):


--- /usr/lib64/ibdiagnet1.2/ibdebug.tcl	2009-06-03 13:11:09.000000000 -0700
+++ /usr/lib64/ibdiagnet1.2/ibdebug.tcl.orig	2009-06-03 11:01:06.000000000 -0700
@@ -3064,7 +3064,6 @@ proc GetPortPkeys {drPath portNum numPKe
 	    inform "-E-ibdiagnet:PKeys.getPkey" $drPath $portNum $block
 	    continue
 	}
-        set pkeyTable [RemoveElementFromList $pkeyTable "-pkey_entry"]
 	foreach pkey $pkeyTable {
 	    if {$pkey != 0} {
 		lappend pkeys $pkey