[ofa-general] Re: ibdiagnet: invalid bareword "pkey_entry"

[Yevgeny Kliteynik]

Hi Arthur,

Thanks for reporting this.

akepner at sgi.com wrote:
> (Yevgeny, looks like you're maintaining ibutils. Please let me 
> know if it's otherwise.)
> 
> We're getting this:
> 
> # ibdiagnet
> .....
> -I---------------------------------------------------
> -I- Fabric Partitions Report (see ibdiagnet.pkey for a full hosts list)
> -I---------------------------------------------------
> invalid bareword "pkey_entry"
> in expression "-pkey_entry & 0x7fff";
> should be "$pkey_entry" or "{pkey_entry}" or "pkey_entry(...)" or ...
> # 

This was fixed in OFED 1.4.1 and main trunk:

http://www.openfabrics.org/git/?p=~kliteyn/ibutils.git;a=commit;h=2d0eaa74cc5d1b62cdfa8e2b310e28431d33b951

Are you using OFED 1.4?

-- Yevgeny

 
> when running ibdiagnet. 
> 
> Any idea why we're seeing this now, when we haven't before?
> 
> The following fixes it, but maybe there's a better way (it's 
> the first line of tcl I've ever written):
> 
> 
> --- /usr/lib64/ibdiagnet1.2/ibdebug.tcl	2009-06-03 13:11:09.000000000 -0700
> +++ /usr/lib64/ibdiagnet1.2/ibdebug.tcl.orig	2009-06-03 11:01:06.000000000 -0700
> @@ -3064,7 +3064,6 @@ proc GetPortPkeys {drPath portNum numPKe
>  	    inform "-E-ibdiagnet:PKeys.getPkey" $drPath $portNum $block
>  	    continue
>  	}
> -        set pkeyTable [RemoveElementFromList $pkeyTable "-pkey_entry"]
>  	foreach pkey $pkeyTable {
>  	    if {$pkey != 0} {
>  		lappend pkeys $pkey
> 

2d0eaa74cc5d1b62cdfa8e2b310e28431d33b951
 ibdiag/src/ibdebug.tcl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ibdiag/src/ibdebug.tcl b/ibdiag/src/ibdebug.tcl
index a36774b..28ce3a7 100644
--- a/ibdiag/src/ibdebug.tcl
+++ b/ibdiag/src/ibdebug.tcl
@@ -3048,7 +3048,7 @@ proc GetPortPkeys {drPath portNum numPKeys} {
 	    continue
 	}
 	foreach pkey $pkeyTable {
-	    if {$pkey != 0} {
+	    if {[regexp {^0x[0-9a-fA-F]$} $pkey]} {
 		lappend pkeys $pkey
 	    }
 	}